-
Notifications
You must be signed in to change notification settings - Fork 27.4k
update angular-mocks.js url matching #12762
Conversation
url matching was incorrect and updated. if all query parameters in url are in different order, it should still match
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thanks for this @deodeveloper - before we can land this change it would need to have a unit test to show that it is doing what you expect. |
For merging with master, updated a test case for the changes related to this the pull request as commented by @petebacondarwin |
There are some stying issues (e.g. see https://travis-ci.org/angular/angular.js/jobs/106143760). |
@@ -1646,6 +1646,15 @@ function MockHttpExpectation(method, url, data, headers) { | |||
} | |||
return data == d; | |||
}; | |||
|
|||
this.getUrlParams = function (u){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these two methods (getUrlParams
and compareUrl
) need to be public ?
This doesn't properly support URLs with a hash fragment, but I guess we don't really care, because it doesn't make sense to make requests against URLs with a hash fragment (since hash fragments have no meaning for the server). |
@deodeveloper can you address the issues that @gkalpak has highlighted? |
url matching was incorrect and updated. if all query parameters in url are in different order, it should still match